FINERACT-2437: Decrease compilation warnings#5721
Open
rhopman wants to merge 1 commit intoapache:developfrom
Open
FINERACT-2437: Decrease compilation warnings#5721rhopman wants to merge 1 commit intoapache:developfrom
rhopman wants to merge 1 commit intoapache:developfrom
Conversation
DeathGun44
reviewed
Mar 31, 2026
| @Override | ||
| public Integer fetchCurrentVersionNumber(Long loanId) { | ||
| final String sql = "select MAX(lrs.version) from m_loan_repayment_schedule_history lrs where lrs.loan_id = ?"; | ||
| Integer max = this.jdbcTemplate.queryForObject(sql, new Object[] { loanId }, Integer.class); |
Contributor
There was a problem hiding this comment.
The jdbcTemplate.queryForObject(String, Object[], Class) method call is also deprecated (since Spring 5.3). If we are removing @SuppressWarnings("deprecation") ,please consider addressing that aswell!
Contributor
Author
There was a problem hiding this comment.
Good catch, @DeathGun44. I have changed it now to the new varargs form.
Aman-Mittal
approved these changes
Mar 31, 2026
Contributor
Aman-Mittal
left a comment
Aman-Mittal
left a comment
There was a problem hiding this comment.
Seems ok, While i also support Krishna's suggestion too.
@adamsaghy i think it is ready for review
rhopman
force-pushed
the
FINERACT-2437-decrease-compilation-warnings
branch
from
99d190b to
7d19ff3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace deprecated method calls with their modern equivalents across several modules:
ObjectUtils.defaultIfNull(deprecated in Commons Lang 3.15) →Objects.requireNonNullElsein 8 files across fineract-charge, fineract-core, fineract-loan, fineract-provider, and fineract-progressive-loanRandomStringUtils.randomAlphabetic(static call on instance) →nextAlphabeticinDefaultContentPathRandomizerStopWatch.getStartTime(deprecated in Commons Lang 3.12) →getStartInstant().toEpochMilli()inPlatformRequestLog@Schema(required = true)(deprecated in Swagger 2.2) →@Schema(requiredMode = Schema.RequiredMode.REQUIRED)inAuthenticationApiResourceSwaggerPaymentTypeRepositoryWrapper(marked@Deprecated(forRemoval = true)) → replaced with directPaymentTypeRepositoryusage inPaymentDetailAssembler,PaymentDetailWritePlatformServiceJpaRepositoryImpl, andPaymentDetailConfigurationNo behavioural changes.
Checklist